Fix minor problems found by static checking.

* eval.c (get_backtrace_frame, backtrace_eval_unrewind): Now static.
(backtrace_eval_unrewind): ';' -> '{}' to pacify GCC.

diff --git a/src/ChangeLog b/src/ChangeLog
index c8aebbff2c28894e4a4646b316345ff8ce2d6d6f..83017eeec808b0c831e0e3a3d0591ab718df4d0d 100644 (file)
--- a/src/ChangeLog
+++ b/src/ChangeLog
@@ -1,3 +1,9 @@
+2013-07-26  Paul Eggert  <eggert@cs.ucla.edu>
+
+       Fix minor problems found by static checking.
+       * eval.c (get_backtrace_frame, backtrace_eval_unrewind): Now static.
+       (backtrace_eval_unrewind): ';' -> '{}' to pacify GCC.
+
 2013-07-26  Stefan Monnier  <monnier@iro.umontreal.ca>
 
        * eval.c (set_specpdl_old_value): New function.

diff --git a/src/eval.c b/src/eval.c
index e55a3b259e0a8e4c3f955cf6df7d1ad3c7ae1eb8..bb5d5efc9ba6f1c635aa96d054f75951acdc30ca 100644 (file)
--- a/src/eval.c
+++ b/src/eval.c
@@ -3424,7 +3424,7 @@ Output stream used is value of `standard-output'.  */)
   return Qnil;
 }
 
-union specbinding *
+static union specbinding *
 get_backtrace_frame (Lisp_Object nframes, Lisp_Object base)
 {
   union specbinding *pdl = backtrace_top ();
@@ -3483,7 +3483,7 @@ nearest activation frame.  */)
    pointer-reversal trick.  As it turns out, the rewind does the same as the
    unwind, except it starts from the other end of the spepdl stack, so we use
    the same function for both unwind and rewind.  */
-void
+static void
 backtrace_eval_unrewind (int distance)
 {
   union specbinding *tmp = specpdl_ptr;
@@ -3524,10 +3524,11 @@ backtrace_eval_unrewind (int distance)
              break;
            }
          else
-           /* FALLTHROUGH!
-              NOTE: we only ever come here if make_local_foo was used for
-              the first time on this var within this let.  */
-           ;
+           {
+             /* FALLTHROUGH!
+                NOTE: we only ever come here if make_local_foo was used for
+                the first time on this var within this let.  */
+           }
        case SPECPDL_LET_DEFAULT:
          {
            Lisp_Object sym = specpdl_symbol (tmp);